Multitasking: redesign#310
Conversation
|
|
|
My initial reaction is that the comboboxes are a lot wider than the text therein, which looks a bit odd. |
|
Should #299 be merged first - I guess this layout works better with that design? |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Code looks good.Just left a comment about appearance.
Also it looks like the settings and gala has the ability to have different custom commands assigned to different corners. As you can choose "custom command" for more than one corner it would make sense to have separate entries for each command command rather than an obscure way of entering multiple commands into one entry. This layout would facilitate that.
|
You're right! I didn't realize that was possible. I'll update this branch to take advantage of that. From gsettings:
|
|
@jeremypw okay you should be able to set per-corner custom commands now!
|
|
Yeah, I did not know until I saw the description of the setting - not exactly discoverable! |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Looks good now. Just a couple of bits of residual debugging code (lines 94, 210).
It might be better to use a variant array to store the custom commands, like Files tab info does, rather than manipulating strings but that can be considered later.
|
Yeah I think ideally this should probably be a string array in Gala's gsettings. It's pretty ugly like you said doing this string manipulation |
2 participants
Uh oh!
There was an error while loading. Please reload this page.